Skip to content

feat: Kubernetes recommended labels #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: Kubernetes recommended labels #175

wants to merge 1 commit into from

Conversation

nlamirault
Copy link

@nlamirault nlamirault commented Aug 8, 2025 •
edited
Loading

  • Support all Kubernetes recommended labels
  • Refactoring using template helper.
  • Support for additional labels which can be add to all resources
  • Change labelSelector into metrics-service to use the same of the deployment.

@nlamirault
feat: Kubernetes recommended labels
693886c 
Signed-off-by: Nicolas Lamirault <[email protected]>
@ack-prow ack-prow bot requested review from knottnt and michaelhtm August 8, 2025 17:04
@ack-prow ACK Prow
Copy link

ack-prow bot commented Aug 8, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nlamirault
Once this PR has been reviewed and has the lgtm label, please assign a-hilaly for approval by writing /assign @a-hilaly in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 8, 2025
@ack-prow ACK Prow
Copy link

ack-prow bot commented Aug 8, 2025

Hi @nlamirault. Thanks for your PR.

I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knottnt knottnt Awaiting requested review from knottnt

@michaelhtm michaelhtm Awaiting requested review from michaelhtm

Assignees
No one assigned
Labels
needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nlamirault